Skip to content

Fix wrong data type for data_checksums parameter #1420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 24, 2023
Merged

Fix wrong data type for data_checksums parameter #1420

merged 1 commit into from
Apr 24, 2023

Conversation

smortex
Copy link
Collaborator

@smortex smortex commented Apr 23, 2023 •
edited
Loading

When adding data types, this Boolean value has been assigned a String[1] data type in some places, which break existing setup.

Consistently use an Optional[Boolean] data type.

Fixes #1419

@smortex
Fix wrong data type for data_checksums parameter
e433ebb 
When adding data types, this Boolean value has been assigned a String[1]
data type in some places, which break existing setup.

Consistently use an `Optional[Boolean]` data type.

Fixes #1419
@smortex smortex requested a review from a team as a code owner April 23, 2023 02:46
@puppet-community-rangefinder
Copy link

postgresql::globals is a class

Breaking changes to this file WILL impact these 20 modules (exact match):
Breaking changes to this file MAY impact these 2 modules (near match):

postgresql::server is a class

Breaking changes to this file WILL impact these 42 modules (exact match):
Breaking changes to this file MAY impact these 17 modules (near match):

This module is declared in 70 of 580 indexed public Puppetfiles.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@smortex smortex added the bugfix label Apr 23, 2023
jordanbreen28
jordanbreen28 approved these changes Apr 24, 2023
View reviewed changes
Copy link
Contributor

@jordanbreen28 jordanbreen28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting this fix in so quick @smortex.

@jordanbreen28 jordanbreen28 merged commit 67ab5cb into main Apr 24, 2023
@jordanbreen28 jordanbreen28 deleted the fix-data_checksums-data-type branch April 24, 2023 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jordanbreen28 jordanbreen28 jordanbreen28 approved these changes

Assignees
No one assigned
Labels
bugfix community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[9.0.0] data_checksums settings inconsistent and breaks existing code
3 participants
@smortex @jordanbreen28 @ia-content